Mark azure-functions-durable as typed - #246
Merged
andystaples merged 3 commits intoJul 30, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3775188c-77e9-48a2-9c79-76e7bfdc25f9
Contributor
There was a problem hiding this comment.
Pull request overview
Adds PEP 561 typed-package support for the azure-functions-durable provider so strict type checkers recognize azure.durable_functions, and introduces a packaging/type-check smoke test that validates the marker is present in both wheel and sdist artifacts.
Changes:
- Add
azure.durable_functions/py.typedand include it in distribution package data. - Extend
nox -s typecheck_functionsto build wheel/sdist, verifypy.typedis present, and run a strict Pyright “consumer import” check against the installed wheel. - Add a strict Pyright smoke-test project under
tests/azure-functions-durable/typingand document the user-facing change in the changelog.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/azure-functions-durable/typing/pyrightconfig.json | Adds a strict Pyright config for the consumer import smoke test. |
| tests/azure-functions-durable/typing/import_package.py | Minimal strict-typed consumer import exercising azure.durable_functions + DFApp. |
| noxfile.py | Builds and validates artifacts in typecheck_functions, then runs consumer Pyright against the installed wheel. |
| azure-functions-durable/pyproject.toml | Ensures py.typed is shipped via setuptools package data. |
| azure-functions-durable/CHANGELOG.md | Documents the new typed-package behavior under Unreleased. |
| azure-functions-durable/azure/durable_functions/py.typed | Adds the PEP 561 marker file to the package. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3775188c-77e9-48a2-9c79-76e7bfdc25f9
berndverst
reviewed
Jul 29, 2026
berndverst
left a comment
berndverst
left a comment
Member
There was a problem hiding this comment.
Found one reproducible gap in the packaged-consumer validation; see the inline comment.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3775188c-77e9-48a2-9c79-76e7bfdc25f9
berndverst
approved these changes
Jul 30, 2026
berndverst
left a comment
berndverst
left a comment
Member
There was a problem hiding this comment.
Verified the packaged consumer check resolves fresh provider and core wheels under strict Pyright, including a reused nox -R environment. The prior core-backed typing gap is resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
py.typedmarker withazure-functions-durableValidation
nox -s typecheck_functionsnox -s lint -- noxfile.py azure-functions-durable tests/azure-functions-durablenox -s functions_unit-3.13Fixes #242